feat(maven-plugin) add m2e metadata #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 69 69
Lines 2245 2245
Branches 590 590
=======================================
Hits 2078 2078
Misses 120 120
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcollovati
approved these changes
Jul 17, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
cromoteca
added a commit
that referenced
this pull request
Jul 18, 2024
feat(maven-plugin) add m2e metadata (#2610) Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
lifecycle-mapping-metadata.xmllike in Flow plugin, but usinggenerateas incremental goal.Should fix both vaadin/platform#6562 and vaadin/platform#6590.