Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchors with query parameters or hashes dont work #261

Closed
LarsDenBakker opened this issue Sep 5, 2018 · 0 comments · Fixed by #341
Closed

Anchors with query parameters or hashes dont work #261

LarsDenBakker opened this issue Sep 5, 2018 · 0 comments · Fixed by #341
Labels
bug Something isn't working hilla
Milestone
CCDM MVP

Comments

@LarsDenBakker
Copy link

LarsDenBakker commented Sep 5, 2018 •
edited

In the current setup, anchors with query parameters or hashes do not work:

<a href="/foo?foo=bar">foo</a>
<a href="/foo#foo=bar">foo</a>

Clicking on these anchors, both route to /foo without the query params or hash.

Even if query params are not currently supported as a path to match on, it should at least still be reflected to the URL.
@vlukashov vlukashov added the bug Something isn't working label Oct 5, 2018
@platosha platosha mentioned this issue Aug 8, 2019
Merged
vlukashov pushed a commit that referenced this issue Aug 12, 2019
@platosha
feat: keep search and hash URL parts when navigating (#341)
58281f7 
* fix: add ?search and #hash support to click trigger
* fix: add ?search and #hash support to popstate trigger
* feat: make Router keep search and hash URL parts
* chore: update rendered docs

Fixes #261
@vlukashov vlukashov added this to the CCDM MVP milestone Aug 12, 2019
@mantissa7 mantissa7 mentioned this issue Aug 19, 2019
Closed
@vlukashov vlukashov mentioned this issue Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hilla
Projects
None yet
Milestone
CCDM MVP
Development

Successfully merging a pull request may close this issue.

feat: keep search and hash URL parts when navigating vaadin/router
2 participants
@LarsDenBakker @vlukashov