Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep search and hash URL parts when navigating #341

Merged
merged 4 commits into from
Aug 12, 2019
Merged

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Aug 8, 2019

Fixes #261


This change is Reviewable

src/router.js Outdated Show resolved Hide resolved
src/router.js Show resolved Hide resolved
@platosha platosha force-pushed the fix/261 branch 2 times, most recently from 55f812a to 4b77165 Compare August 9, 2019 11:35
Copy link
Contributor

@vlukashov vlukashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 44 files at r1, 5 of 5 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @vlukashov)

Copy link
Contributor

@vlukashov vlukashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@vlukashov vlukashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@vlukashov vlukashov merged commit 58281f7 into master Aug 12, 2019
@vlukashov vlukashov deleted the fix/261 branch August 12, 2019 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchors with query parameters or hashes dont work
2 participants