Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most components do not fit inside standard cell size #52

Closed
vaadin-bot opened this issue Jan 22, 2015 · 2 comments
Closed

Most components do not fit inside standard cell size #52

vaadin-bot opened this issue Jan 22, 2015 · 2 comments
Labels

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @tmattsso


When adding e.g. a Button, the bottom of the button is cut off since it won't fit into a cell. Should we automatically resize those rows that contain components? The issue is present with both Rows and Editors.


Imported from https://dev.vaadin.com/ issue #16467

@vaadin-bot
Copy link
Collaborator Author

Originally by @tepi


Review at https://dev.vaadin.com/review/7865

The fix should give enough height for most common vaadin components, and handle the width issue of buttons by adding ellipsis for caption text overflow.

Nothing is done for the widths so a too-wide field is still a problem.

@vaadin-bot
Copy link
Collaborator Author

Originally by @tepi


We could recommend that one should use 100% width for fields. I made this change into SpreadsheetDemoUI in the test folder and this seems to fix the width issue in most cases.

@vaadin-bot vaadin-bot added the bug label Oct 27, 2016
@vaadin-bot vaadin-bot added this to the Spreadsheet 1.0 milestone Oct 27, 2016
alvarezguille pushed a commit that referenced this issue Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant