fix: replace 'blocklist' and 'whitelist' with 'blocked' and 'allowed'

[jouni]

Fixes #645

Mark the existing methods as deprecated and introduce methods with new names.

Fall back to the old configuration properties if the new ones aren't used.

[CLAassistant]

All committers have signed the CLA.

[jouni]

I admit I did the changes almost “blindfolded”. I didn't run any tests or otherwise verify that it works. I hope someone can tell me how to do that, or do it for me 😄

[mcollovati]

A bunch of comments.
Validation is failing, I'll try it locally

[mcollovati]

The same changes should be applied also on Flow repository.

[sonarcloud]

Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[Artur-]

Shouldn't this be done in https://github.com/vaadin/flow/tree/main/vaadin-spring ? This repository is for old Flow versions

[mcollovati]

Shouldn't this be done in https://github.com/vaadin/flow/tree/main/vaadin-spring ? This repository is for old Flow versions

I'll create a PR in the flow repo

[mcollovati]

The PR looks good, but tests are still failing, although they pass locally.
I'm looking into it, but in the meanwhile I'll create a specular PR on the Flow repository

[mcollovati]

vaadin/flow#18405

[mcollovati]

Tests failed because of issues with pnpm cache; browser console reported messages like

http://ip-address:8888/parent-template 0:0 Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegist…-module" has already been used with this registry
http://ip-address:8888/parent-template 0:0 Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegist…-module" has already been used with this registry

Cleaning pnpm cache before executing the validation fixed the job

[mcollovati]

@mshabarov LGTM, I don't know if you also want to take a look at it

[mshabarov]

Looks good to me.

"Blocked-packages" and "allowed-packages" names are inline with what we previously discussed in Slack.

[mshabarov]

We have to pick this into 19.1 branch as well.

[vaadin-bot]

Hi @jouni , this commit cannot be picked to 19.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 0af3dca
error: could not apply 0af3dca... fix: replace 'blocklist' and 'whitelist' with 'blocked' and 'allowed' (#1077)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[jouni]

Thanks for helping out with the finalization tasks!