Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' #18405

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

mcollovati
Copy link
Collaborator

Description

Mark the existing methods as deprecated and introduce methods with new names. Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Copy link

github-actions bot commented Jan 8, 2024

Test Results

1 055 files  ± 0  1 055 suites  ±0   1h 16m 10s ⏱️ + 1m 8s
6 798 tests ± 0  6 753 ✅ ± 0  45 💤 ±0  0 ❌ ±0 
7 084 runs  +15  7 028 ✅ +15  56 💤 ±0  0 ❌ ±0 

Results for commit 3e1c06b. ± Comparison against base commit 7d126d1.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mshabarov mshabarov merged commit be956a9 into main Jan 15, 2024
26 checks passed
@mshabarov mshabarov deleted the chore/spring-blocked-allowed branch January 15, 2024 08:45
vaadin-bot pushed a commit that referenced this pull request Jan 15, 2024
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick be956a9
error: could not apply be956a9... fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (#18405)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Jan 15, 2024
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick be956a9
error: could not apply be956a9... fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (#18405)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot added a commit that referenced this pull request Jan 15, 2024
…#18405) (#18453)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
vaadin-bot added a commit that referenced this pull request Jan 15, 2024
…#18405) (#18452)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
mcollovati added a commit that referenced this pull request Jan 15, 2024
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
mcollovati added a commit that referenced this pull request Jan 15, 2024
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
mshabarov pushed a commit that referenced this pull request Jan 15, 2024
…#18405) (#18456)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
mshabarov pushed a commit that referenced this pull request Jan 15, 2024
…#18405) (#18457)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative names for blacklisted-packages and whitelisted-packages
4 participants