Mark overlay property as readOnly

- Remove @Private from overlay js doc - Mark overlay as readOnly - Add @Private to lifecycle methods
vaadin · Apr 10, 2019 · c4b0c2f · c4b0c2f
1 parent f4f7e5f
commit c4b0c2f
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/vaadin-app-layout.html b/src/vaadin-app-layout.html
@@ -216,11 +216,11 @@
 
             /**
              *  Drawer is an overlay on top of the content
-             *  Controlled via CSS using --vaadin-app-layout-drawer-overlay: true|false;
-             * @private
+             *  Controlled via CSS using `--vaadin-app-layout-drawer-overlay: true|false`;
              */
             overlay: {
               type: Boolean,
+              readOnly: true,
               value: false,
               reflectToAttribute: true
             }
@@ -234,6 +234,9 @@
           this.__drawerToggleClickListener = this._drawerToggleClick.bind(this);
         }
 
+        /**
+        * @private
+        */
         connectedCallback() {
           super.connectedCallback();
 
@@ -265,6 +268,9 @@
           this._updateOverlayMode();
         }
 
+        /**
+        * @private
+        */
         disconnectedCallback() {
           super.disconnectedCallback();
 
@@ -340,7 +346,7 @@
         _updateOverlayMode() {
           const overlay = this._getCustomPropertyValue('--vaadin-app-layout-drawer-overlay') == 'true';
 
-          this.overlay = overlay;
+          this._setOverlay(overlay);
 
           if (this.overlay) {
             this.drawerOpened = false;