Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RTL specific styles [2.1] #155

Merged
merged 3 commits into from
Apr 7, 2020
Merged

feat: add RTL specific styles [2.1] #155

merged 3 commits into from
Apr 7, 2020

Conversation

web-padawan
Copy link
Member

Fixes #152

@DiegoCardoso
Copy link
Contributor

I believe there are some changes missing for the material-drawer-toggle styles. At least, there's one margin-right on the host level, that can be scoped only for LTR. There's one style targeting [part='icon'] that uses left but I didn't see any visual change on using right instead for RTL.

DiegoCardoso
DiegoCardoso approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@web-padawan web-padawan merged commit 43a3764 into 2.1 Apr 7, 2020
@web-padawan web-padawan deleted the rtl-support branch April 7, 2020 13:31
@web-padawan web-padawan mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

@yuriy-fix yuriy-fix Awaiting requested review from yuriy-fix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@web-padawan @DiegoCardoso