Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Add missing add method #156

Merged
merged 2 commits into from
May 7, 2020
Merged

Add missing add method #156

merged 2 commits into from
May 7, 2020

Conversation

anasmi
Copy link

@anasmi anasmi commented May 4, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 4, 2020

CLA assistant check
All committers have signed the CLA.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ButtonView.java#L159: Define a constant instead of duplicating this literal "Button " 3 times. rule
  2. MAJOR ButtonView.java#L251: Either re-interrupt this method or rethrow the "InterruptedException". rule
  3. MAJOR ButtonView.java#L251: Either remove or fill this block of code. rule

@alvarezguille alvarezguille merged commit e731661 into 2.0 May 7, 2020
@alvarezguille alvarezguille deleted the add-missing-add branch May 7, 2020 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants