Update checkbox-group to use required field mixin #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/required-field-mixin
branch
from
26599c1
to
8fb2cab
Compare
This was referenced Sep 13, 2018
|
demo/checkbox-group-validation-demos.html, line 31 at r1 (raw file):
This demo no longer works after the change |
web-padawan
force-pushed
the
fix/required-field-mixin
branch
from
8fb2cab
to
ff7c7cb
Compare
web-padawan
commented
Sep 13, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @web-padawan)
demo/checkbox-group-validation-demos.html, line 31 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
This demo no longer works after the change
Oops, done.
tomivirkki
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
Reviewed 9 of 11 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
limonte
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
Also, some cleanup for checkbox-group demos.
This change is