Update text-field styles to use required field mixin #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platosha
requested changes
Sep 17, 2018
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)
a discussion (no related file):
Fails the visual tests for some reason :-(
platosha
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)
web-padawan
force-pushed
the
chore/required-field-mixin
branch
from
3820708
to
dfc201a
Compare
platosha
approved these changes
Sep 21, 2018
There was a problem hiding this comment.
Reviewed 15 of 15 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @web-padawan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as vaadin/vaadin-checkbox#125
This change is