Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Items not rendered partially after scrolling in large combobox #227

Closed
steffen-harbich-cognitum opened this issue Mar 6, 2019 · 2 comments
Closed

Items not rendered partially after scrolling in large combobox #227

steffen-harbich-cognitum opened this issue Mar 6, 2019 · 2 comments
Assignees
@pekam
Labels
bug
Milestone
2.1.3

Comments

@steffen-harbich-cognitum
Copy link

Have a look at my example based on starter project:
demo-combobox-items-not-rendered.zip

The combobox has a lot of items. When scrolling down and up, some items are not rendered correctly anymore, though they still exist and can be selected:
demo-combobox-items-not-rendered

Same behavior in Vaadin 12.0.7 and 13.0.0.
@denis-anisimov
Copy link

Confirmed.

@denis-anisimov denis-anisimov added this to the 1.0 Maintenance milestone Mar 7, 2019
@pekam
Copy link
Contributor

pekam commented Mar 8, 2019

Seems to happen only when using ComponentRenderer. At least I couldn't reproduce with value providers or templates.

@denis-anisimov denis-anisimov mentioned this issue Mar 11, 2019
Closed
@pekam pekam self-assigned this Mar 11, 2019
pekam added a commit that referenced this issue Mar 12, 2019
@pekam
Add IT for #227
795948e
pekam added a commit that referenced this issue Mar 12, 2019
@pekam
Don't apply new filter to DP if filter not changed
4ca615d 
Otherwise, DataProvider will get a new instance of the filter object
-> DataCommunicator thinks filter changed
-> destroys all data
-> rendered components are destroyed
-> client still thinks that everything is fine
-> flow-component-renderer doesn't find destroyed component instances
-> components not rendered

Fix #227
@pekam pekam mentioned this issue Mar 12, 2019
Merged
pekam added a commit that referenced this issue Mar 18, 2019
@pekam
Don't apply new filter to DP if filter not changed (#231)
1d460f6 
Otherwise, DataProvider will get a new instance of the filter object
-> DataCommunicator thinks filter changed
-> destroys all data
-> rendered components are destroyed
-> client still thinks that everything is fine
-> flow-component-renderer doesn't find destroyed component instances
-> components not rendered

Fix #227
@pekam pekam removed the in review label Mar 18, 2019
pekam added a commit that referenced this issue Mar 18, 2019
@pekam
Don't apply new filter to DP if filter not changed
873d689 
Otherwise, DataProvider will get a new instance of the filter object
-> DataCommunicator thinks filter changed
-> destroys all data
-> rendered components are destroyed
-> client still thinks that everything is fine
-> flow-component-renderer doesn't find destroyed component instances
-> components not rendered

Fix #227
pekam added a commit that referenced this issue Mar 21, 2019
@pekam
Don't apply new filter to DP if filter not changed (#231)
82deeae 
Otherwise, DataProvider will get a new instance of the filter object
-> DataCommunicator thinks filter changed
-> destroys all data
-> rendered components are destroyed
-> client still thinks that everything is fine
-> flow-component-renderer doesn't find destroyed component instances
-> components not rendered

Fix #227
@pekam pekam modified the milestones: 1.0 Maintenance, 2.1.3 Mar 21, 2019
pekam added a commit that referenced this issue Mar 21, 2019
@pekam
Don't apply new filter to DP if filter not changed (#231)
1bface6 
Otherwise, DataProvider will get a new instance of the filter object
-> DataCommunicator thinks filter changed
-> destroys all data
-> rendered components are destroyed
-> client still thinks that everything is fine
-> flow-component-renderer doesn't find destroyed component instances
-> components not rendered

Fix #227
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pekam pekam

Labels
bug
Projects
None yet
Milestone
2.1.3
Development

No branches or pull requests
3 participants
@denis-anisimov @steffen-harbich-cognitum @pekam