This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
Don't apply new filter to DP if filter not changed #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, DataProvider will get a new instance of the filter object -> DataCommunicator thinks filter changed -> destroys all data -> rendered components are destroyed -> client still thinks that everything is fine -> flow-component-renderer doesn't find destroyed component instances -> components not rendered Fix #227
pekam
commented
Mar 14, 2019
vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java
Show resolved
Hide resolved
yuriy-fix
reviewed
Mar 15, 2019
vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java
Outdated
Show resolved
Hide resolved
|
SonarQube analysis reported 4 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
yuriy-fix
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Let's wait for @bogdanudrescu response on this one.
Otherwise, for me
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
pekam
added a commit
that referenced
this pull request
Mar 21, 2019
Otherwise, DataProvider will get a new instance of the filter object -> DataCommunicator thinks filter changed -> destroys all data -> rendered components are destroyed -> client still thinks that everything is fine -> flow-component-renderer doesn't find destroyed component instances -> components not rendered Fix #227
pekam
added a commit
that referenced
this pull request
Mar 21, 2019
Otherwise, DataProvider will get a new instance of the filter object -> DataCommunicator thinks filter changed -> destroys all data -> rendered components are destroyed -> client still thinks that everything is fine -> flow-component-renderer doesn't find destroyed component instances -> components not rendered Fix #227
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, DataProvider will get a new instance of the filter object
-> DataCommunicator thinks filter changed
-> destroys all data
-> rendered components are destroyed
-> client still thinks that everything is fine
-> flow-component-renderer doesn't find destroyed component instances
-> components not rendered
Fix #227
This change is