Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add items property #12

Closed
Saulis opened this issue Oct 16, 2015 · 3 comments
Closed

Add items property #12

Saulis opened this issue Oct 16, 2015 · 3 comments
Milestone
1.0.0-alpha2

Comments

@Saulis
Copy link
Contributor

Saulis commented Oct 16, 2015 •
edited by platosha
Loading

  • Support primitive types only at this point
  • Put a iron-list inside iron-selector
  • vaadin-combo-box should expose items
  • Push, Pop, Empty, Update and other array related mutations need to be tested
@jouni jouni mentioned this issue Oct 20, 2015
Closed
3 tasks
@cwayfinder cwayfinder self-assigned this Oct 20, 2015
cwayfinder added a commit that referenced this issue Oct 20, 2015
@cwayfinder
Add items mutating tests (Fix #12)
79b0082
@cwayfinder cwayfinder mentioned this issue Oct 21, 2015
Merged
@Saulis Saulis closed this as completed Oct 21, 2015
@Saulis Saulis removed the in review label Oct 21, 2015
@Saulis Saulis added this to the 1.0.0-alpha2 milestone Nov 25, 2015
@Saulis Saulis added this to the 1.0.0-alpha2 milestone Nov 25, 2015
@jouni jouni mentioned this issue Feb 15, 2016
Closed
@patriciapds
Copy link

patriciapds commented Apr 18, 2017 •
edited
Loading

@Saulis Any plans to support objects?

@Saulis
Copy link
Contributor Author

Saulis commented Apr 18, 2017

Hi @patriciapds!

If you mean using objects as values instead of string literals, that's already supported: https://cdn.vaadin.com/vaadin-core-elements/latest/vaadin-combo-box/demo/objects.html

@web-padawan
Copy link
Member

web-padawan commented Apr 18, 2017 •
edited
Loading

@patriciapds I think items could accept iterables in the future, once Polymer implements that for dom-repeat, iron-list etc. Is it what you mean?

manolo pushed a commit to vaadin/vaadin-combo-box-flow that referenced this issue Oct 3, 2020
@ZheSun88
Prepare for Release
1a01388 
vaadin/vaadin-combo-box#12

 Using alpha3

Flow-component: vaadin-combo-box
manolo pushed a commit to vaadin/vaadin-combo-box-flow that referenced this issue Oct 3, 2020
@ZheSun88
Prepare for Release
c37effa 
vaadin/vaadin-combo-box#12

 Using alpha3

Flow-component: vaadin-combo-box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha2
Development

No branches or pull requests
4 participants
@cwayfinder @Saulis @web-padawan @patriciapds