Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation #16

Closed
12 of 14 tasks
Saulis opened this issue Oct 20, 2015 · 3 comments
Closed
12 of 14 tasks

Keyboard navigation #16

Saulis opened this issue Oct 20, 2015 · 3 comments
Assignees
Milestone

Comments

@Saulis
Copy link
Contributor

Saulis commented Oct 20, 2015

Features / Behavior:

  • Let's focus on desktop behavior, if it works on fullscreen, great - if not then not.
  • Input can be focused using TAB
  • Popup opens when you start typing on it (or click the icon)
  • Popup opens when focused and you push DOWN/UP
  • If a value is selected when popup opens, it's highlighted, otherwise nothing is highlighted. Selected item is not highlighted after filtering anymore.
  • After typing in a filter, the topmost item is highlighted
  • Focus/highlight is moved up and down by pushing DOWN/UP
  • When you navigate to the topmost item, and push one more time UP, the topmost item stays focused??
  • You need to be able to navigate the value inside the input field using LEFT/RIGHT
  • Pushing ENTER will select the focused/highlighted item
  • When the input box is cleared and ENTER is pushed, combobox value is cleared.
    • Q: How is the input box cleared ? A: With BACKSPACE
    • Q: When input box is empty is it cleared ? A: combobox.value is cleared if ENTER is
      hit when input box is empty/cleared
    • Additional info: when input value is changed, the items are reset and item highlight is removed.
  • When the input box is cleared we don't want to highlight the topmost item
  • Pushing SPACEBAR is for now reserved for multi selection
  • Pushing ESCAPE will cancel and close the popup

Design questions:

  • When you navigate to the topmost item, and push one more time UP, the topmost item stays focused? or should it remove focus
@Saulis
Copy link
Contributor Author

Saulis commented Oct 25, 2015

One feature missing from our list is that the list of items should of course scroll when it's navigated down or up. I think that we need to implement that in #22 though.

@Saulis Saulis assigned Saulis and unassigned manolo Oct 26, 2015
@Saulis
Copy link
Contributor Author

Saulis commented Oct 26, 2015

@JouniK @tuomasnironen have we discussed if the overlay should be modal or not?

If not, then we can set allowOutsideScroll true in <iron-dropdown> to receive arrow down and up events correctly. Otherwise we need to have a monkey patch to hack into the dropdown scrolling manager.

@Saulis
Copy link
Contributor Author

Saulis commented Oct 27, 2015

While discussing with Tuomas, I tested with allowOutsideScroll = true and the end result was quite unacceptable; the page does scroll but the overlay has fixed position and it detaches from the input field and starts hovering down the page following the scrolling actions.

@manolo manolo closed this as completed Oct 27, 2015
@manolo manolo removed the in review label Oct 27, 2015
@Saulis Saulis modified the milestone: 1.0.0-alpha2 Nov 25, 2015
@jouni jouni mentioned this issue Feb 15, 2016
manolo pushed a commit to vaadin/vaadin-combo-box-flow that referenced this issue Oct 3, 2020
vaadin/vaadin-combo-box#16


Flow-component: vaadin-combo-box
manolo pushed a commit to vaadin/vaadin-combo-box-flow that referenced this issue Oct 3, 2020
vaadin/vaadin-combo-box#16


Flow-component: vaadin-combo-box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants