Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open nested submenu on Enter or Space #231

Closed
web-padawan opened this issue Apr 4, 2019 · 1 comment · Fixed by #232
Closed

Open nested submenu on Enter or Space #231

web-padawan opened this issue Apr 4, 2019 · 1 comment · Fixed by #232
Assignees
Labels
bug Something isn't working
Projects

Comments

@web-padawan
Copy link
Member

Enter or Space should open nested sub-menu when executed on a parent item, based on the example. Currently, only Arrow Right opens it.

@web-padawan web-padawan added the bug Something isn't working label Apr 4, 2019
@web-padawan web-padawan added this to Issue Backlog in vaadin-core Apr 4, 2019
@pekam pekam moved this from Issue Backlog to 🏗  In Progress in vaadin-core Apr 5, 2019
@pekam pekam self-assigned this Apr 5, 2019
pekam added a commit that referenced this issue Apr 5, 2019
pekam added a commit that referenced this issue Apr 5, 2019
@pekam pekam moved this from 🏗  In Progress to 🔬  In Review [4] in vaadin-core Apr 5, 2019
@pekam pekam closed this as completed in #232 Apr 9, 2019
vaadin-core automation moved this from 🔬  In Review [4] to ✅ Done Apr 9, 2019
pekam added a commit that referenced this issue Apr 9, 2019
@pekam pekam removed the in review label Apr 9, 2019
@lkraav
Copy link

lkraav commented Nov 2, 2019

Apparently this has a side-effect where inputs inside <vaadin-context-menu-item> aren't able to type Space keys.

This is my element configuration, where in <input type="search"> I can only type "Helloworld", not "Hello world":

          <vaadin-tab class="menu-item menu-item-search">
            <a>Search</a> &nbsp;
            <vaadin-context-menu close-on="outside-click" open-on="click" class="sub-menu">
              <template>
                <vaadin-context-menu-item>
                  <form role="search" method="get" id="vaadin-context-menu-search-form" class="search-form" action="https://conversionxl.com/institute/">
                    <label for="s">Search CXL Institute:</label>
                    <div>
                      <input type="search" class="search-field" placeholder="" value="" name="s">
                      <vaadin-button type="submit" class="search-submit" aria-label="Search" theme="icon" onclick="document.getElementById('vaadin-context-menu-search-form').submit();">
                        <iron-icon icon="lumo:angle-right"></iron-icon>
                      </vaadin-button>
                    </div>
                  </form>
                </vaadin-context-menu-item>
              </template>
              <iron-icon icon="lumo:search"></iron-icon> 
            </vaadin-context-menu>
          </vaadin-tab>

lkraav added a commit to conversionxl/aybolit that referenced this issue Nov 11, 2019
commit eee03b74ee8383d448908908ab77839ef5976207
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 15:31:39 2019 +0200

    Help decorator support on Windows, fixup 7d294ae

commit ba52bcd3e343034555dc4aa4da6b86988b5d2161
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 14:15:23 2019 +0200

    Enable Pika build decorator support [1], fixup 7d294ae

    For some reason root `babel.config.js` is not recognized, or we don't know
    how to configure it.

    RESEARCH

    * FredKSchott/standard-pkg#9
    * FredKSchott/standard-pkg@1a80ff5
    * https://babeljs.io/docs/en/config-files#monorepos
    * https://github.com/web-padawan/aybolit/blob/v0.1.0/babel.config.js#L15

    1: https://gitter.im/aybolitjs/community?at=5dc94b3d5eb2e813db04bdf4

commit 104c52aee026ab4f5d67ca0f9b5a18450fa4f46f
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 12:12:18 2019 +0200

    Upgrade Pika

commit 55b9f6c858cbb2cb4214e68520fea4eec0ae5312
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 11:36:36 2019 +0200

    Deploy Storybook to GH Pages

commit bd2828a2574eb60baf77d4cccb3176929d3c24bb
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 22:34:43 2019 +0200

    Improve context menu overlay position

commit 9290851a43cefdc0126df1e1de09edc47b760fc2
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 21:40:31 2019 +0200

    Add missing imports

commit 4c9b3ae8bfdf474f91a70f69457da469aae471d8
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 20:37:48 2019 +0200

    Refactor away from split button navigation [1]

    1: https://www.nngroup.com/articles/split-buttons-navigation/

commit 37349e36d135b674bee1009e664f4c42710d802b
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 19:00:22 2019 +0200

    More Global nav items, rename Shadow -> Global

commit 7d294aec818fc3d7bebc2cf041ee98dd2a109b93
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 17:39:19 2019 +0200

    Convert to TC39 decorators [1]

    1: https://lit-element.polymer-project.org/guide/properties#declare-with-decorators

commit 4a3eac799f2654d1749cdfd0d21c15500607a722
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 14:57:55 2019 +0200

    CXL Live icon

commit acbdbe38c05ecd912bfe4f2bcfb2b781e9fb06fd
Author: Leho Kraav <leho@kraav.com>
Date:   Sat Nov 9 23:54:39 2019 +0200

    Wip shadow menu

commit 4f8623def1f3abe47333a413801fbd2b7e04ed85
Author: Leho Kraav <leho@kraav.com>
Date:   Sat Nov 9 15:50:17 2019 +0200

    Storybook 5.3.0-alpha.42 [1] HMR full page reloads [2]

    1: storybookjs/storybook#8400
    2: https://github.com/storybookjs/storybook/tree/v5.3.0-alpha.42/app/web-components#user-content-setup-page-reload-via-hmr

commit b71f42034d1496055a98d915e5425fc91c71c83d
Author: Leho Kraav <leho@kraav.com>
Date:   Sat Nov 9 15:08:41 2019 +0200

    Storybook 5.2.6

commit 58009c953cf3d32c938cf856204ac18c89c8f012
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 19:22:06 2019 +0200

    Search form label brand color

commit ab9359d3af5682ebf4e617d64ee3e4897e64f093
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 15:49:45 2019 +0200

    Embedded search form can now receive all keyboard input

commit 289535c2d591be2027c074e08710ac8f89ab04f4
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 15:08:56 2019 +0200

    Drop apparently unnecessary imports

commit 7f61645f7e0809dd09f7af0411c49a2e0dad866e
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 14:24:31 2019 +0200

    @todo refactor Resize event listener towards removable in `disconnectedCallback()`

commit c58d6eea0ed4311fb72d79a77bf6321202d2354b
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 11:56:59 2019 +0200

    Improve Search menu item form curiosities

commit d40af0ecd12daa3d606b0289c748bcc3981738cc
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 10:02:14 2019 +0200

    ESLint

commit 519d17fc486072813a043e8ba8b96e4651b3bcc5
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 17:53:41 2019 +0200

    Refactor fixed scroll listener, remove `that` pattern

commit 5bfe7f52e04cea0914af74b46fbf5d2074730c30
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 17:01:01 2019 +0200

    Integrate vaadin-tabs resize listener

commit 0d368f2f356c554bed3fa2405210b8d8fd396348
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 16:34:20 2019 +0200

    Refactor context menu dropdown icon vs menu item spacing

commit 3590baf34cebc2f69b9b6291474381e66c52c1e3
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 16:44:41 2019 +0200

    Align Search menu item template with general context menu items population strategy

commit 409aed9bb159454b5f09702970cc635bda9a36c2
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 12:13:02 2019 +0200

    Search menu item's full box should trigger context menu

commit 16192b015834e3ead778279574571d95ed8597f5
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 14:59:11 2019 +0200

    CSS class configuration for split nav menu item

commit 4f099e1d313bb1cf62d8835c637a3dccf606d7eb
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 14:39:55 2019 +0200

    CXLMarketingNavElement.contextMenuItems property and configuration engine

commit f30db212e2ac82c63459a136d4e7f08b9085281d
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 13:00:20 2019 +0200

    Move utility <nav> wrap to shadow DOM

commit 6348064310227f1eca39b99ad08c783060e6260a
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 11:14:31 2019 +0200

    Refactor cxl-marketing-nav

commit 9a5932738a636bd2bf4e091de4779dd3e7ac8ccd
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:33:50 2019 +0200

    Integrated search box menu item

    @todo search input fails to take Space, Enter keydown [1]

    1: vaadin/vaadin-context-menu#231 (comment)

commit fa209831dade6884c0437d979dd104fa6542f6b3
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:43:40 2019 +0200

    Match simple menu items HTML whitespace w/ complex

commit 989ae01e19b2ff2a6d1f19fc767db6c938238e47
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:42:40 2019 +0200

    Improve team invite menu item spacing

commit fca1edebc911f7f1a3bf6eefe04ae0c251dd158e
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:44:32 2019 +0200

    Add logo menu item dropdown

commit cd9747da800bea2569ce31bec97a58ff57f9b4f2
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 1 10:10:56 2019 +0200

    Match `resizeVaadinTabs()` wide width w/ vaadin-context-menu [1]

    1: https://github.com/vaadin/vaadin-context-menu/issues/253

commit f6584d21e00664683285975184fbea43653870bb
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 19:25:22 2019 +0200

    Upgrade to @vaadin/vaadin-context-menu-4.3.12

    Ran into duplicate packages: "Custom element already defined"

    ```
    $ yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-context-menu
    $ yarn-deduplicate
    $ yarn
    ```

commit dbfbe243cd3e5369e61365f90f08abd1bed672fb
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 19:22:17 2019 +0200

    Make narrow viewport menu horizontal scroll icons visible

commit 88f8572ced8f8c4cdfba20f3cc9ca9bddd93ac18
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 16:20:49 2019 +0200

    Force vaadin-tab slotted links hover text-underline [1]

    `yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-tabs`
    helped acquire @vaadin/vaadin-themable-mixin-1.5.0+ [2]

    1: vaadin/vaadin-tabs#134 (comment)
    2: https://github.com/vaadin/vaadin-themable-mixin/releases/tag/v1.5.0

commit cb678593820364c17f02323c8401488c3720d831
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 15:14:20 2019 +0200

    Menu background color --lumo-black

    * Refactor cxl:logo SVG icon, 24px height
    * Add matching cxl:logo[theme=dark] icon
    * Avoid cxl-marketing-nav element margin collapse

commit a3533b5174c29a1db8e6312735695e4547d9b99b
Author: Leho Kraav <leho@kraav.com>
Date:   Wed Oct 30 21:28:39 2019 +0200

    Partially revert 5cbc1b6, re-simplify story tree structure

commit e7dbdb8411b8772a0fabb4d494911ac122121f01
Author: Leho Kraav <leho@kraav.com>
Date:   Wed Oct 30 21:15:56 2019 +0200

    Increase dropdown icon hover visual prominence

commit c2a5143f8e36c99b0e798055244f1398765f8c60
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 19:06:52 2019 +0200

    Make vaadin-tabs orientation respond to window resize

commit cf280c9537e49f8ccad2d1a38d8f78050d0f79e1
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 18:37:51 2019 +0200

    Horizontal split navigation pattern

commit d84596c07b3106951f368df5b03793774ae87f6a
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 18:37:21 2019 +0200

    Add CXL logo menu item

commit 4ada5e545a23cf1ec77ffc750433adf50ae70a62
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 17:20:26 2019 +0200

    Context menu should open on "click" event

commit 857c4bb33f31f09f726ca97912361b800c54b6e7
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 16:57:03 2019 +0200

    Wrap vaadin-tabs in semantic nav element

commit 141b3532468078dc9c8a611ce534d9dd427bad46
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 16:37:16 2019 +0200

    Move context menu trigger outside menu item link

commit 055d2e80c85ac82da2c185e3406b654107146061
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 16:27:59 2019 +0200

    Prototype links inside vaadin-context-menu

commit c8280c72f09ba4c2b98f6a5a2dbb2935b0b3ad49
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 15:46:35 2019 +0200

    Many more contextMenuItems

commit 9b57508ea38f60a478e22ed81abb2bf3142d34fa
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 08:57:00 2019 +0200

    Nav container element (currently unknown) defaults to `display: inline`, we need `block`

commit 4583f1729587ad14f340ea7f0cc3d2f52d334b9a
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 08:06:11 2019 +0200

    Add links, drop unnecessary menu-item-depth classes

commit eab7f786b851f2a7f7bdbe6623e60dc3a7761af7
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 08:04:27 2019 +0200

    Eliminate viewport vertical scrollbar

commit 5cbc1b6367cee0929756a33e6464f2ec630ac4b9
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Oct 28 23:09:12 2019 +0200

    Storybook CSF format

commit 20dc156026eed03b9cb3df0b76bb663713cd9503
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Oct 28 16:45:27 2019 +0200

    Wip cxl-marketing-nav v2 prototype
lkraav added a commit to conversionxl/aybolit that referenced this issue Nov 12, 2019
commit eee03b74ee8383d448908908ab77839ef5976207
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 15:31:39 2019 +0200

    Help decorator support on Windows, fixup 7d294ae

commit ba52bcd3e343034555dc4aa4da6b86988b5d2161
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 14:15:23 2019 +0200

    Enable Pika build decorator support [1], fixup 7d294ae

    For some reason root `babel.config.js` is not recognized, or we don't know
    how to configure it.

    RESEARCH

    * FredKSchott/standard-pkg#9
    * FredKSchott/standard-pkg@1a80ff5
    * https://babeljs.io/docs/en/config-files#monorepos
    * https://github.com/web-padawan/aybolit/blob/v0.1.0/babel.config.js#L15

    1: https://gitter.im/aybolitjs/community?at=5dc94b3d5eb2e813db04bdf4

commit 104c52aee026ab4f5d67ca0f9b5a18450fa4f46f
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 12:12:18 2019 +0200

    Upgrade Pika

commit 55b9f6c858cbb2cb4214e68520fea4eec0ae5312
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Nov 11 11:36:36 2019 +0200

    Deploy Storybook to GH Pages

commit bd2828a2574eb60baf77d4cccb3176929d3c24bb
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 22:34:43 2019 +0200

    Improve context menu overlay position

commit 9290851a43cefdc0126df1e1de09edc47b760fc2
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 21:40:31 2019 +0200

    Add missing imports

commit 4c9b3ae8bfdf474f91a70f69457da469aae471d8
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 20:37:48 2019 +0200

    Refactor away from split button navigation [1]

    1: https://www.nngroup.com/articles/split-buttons-navigation/

commit 37349e36d135b674bee1009e664f4c42710d802b
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 19:00:22 2019 +0200

    More Global nav items, rename Shadow -> Global

commit 7d294aec818fc3d7bebc2cf041ee98dd2a109b93
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 17:39:19 2019 +0200

    Convert to TC39 decorators [1]

    1: https://lit-element.polymer-project.org/guide/properties#declare-with-decorators

commit 4a3eac799f2654d1749cdfd0d21c15500607a722
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 10 14:57:55 2019 +0200

    CXL Live icon

commit acbdbe38c05ecd912bfe4f2bcfb2b781e9fb06fd
Author: Leho Kraav <leho@kraav.com>
Date:   Sat Nov 9 23:54:39 2019 +0200

    Wip shadow menu

commit 4f8623def1f3abe47333a413801fbd2b7e04ed85
Author: Leho Kraav <leho@kraav.com>
Date:   Sat Nov 9 15:50:17 2019 +0200

    Storybook 5.3.0-alpha.42 [1] HMR full page reloads [2]

    1: storybookjs/storybook#8400
    2: https://github.com/storybookjs/storybook/tree/v5.3.0-alpha.42/app/web-components#user-content-setup-page-reload-via-hmr

commit b71f42034d1496055a98d915e5425fc91c71c83d
Author: Leho Kraav <leho@kraav.com>
Date:   Sat Nov 9 15:08:41 2019 +0200

    Storybook 5.2.6

commit 58009c953cf3d32c938cf856204ac18c89c8f012
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 19:22:06 2019 +0200

    Search form label brand color

commit ab9359d3af5682ebf4e617d64ee3e4897e64f093
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 15:49:45 2019 +0200

    Embedded search form can now receive all keyboard input

commit 289535c2d591be2027c074e08710ac8f89ab04f4
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 15:08:56 2019 +0200

    Drop apparently unnecessary imports

commit 7f61645f7e0809dd09f7af0411c49a2e0dad866e
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 14:24:31 2019 +0200

    @todo refactor Resize event listener towards removable in `disconnectedCallback()`

commit c58d6eea0ed4311fb72d79a77bf6321202d2354b
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 11:56:59 2019 +0200

    Improve Search menu item form curiosities

commit d40af0ecd12daa3d606b0289c748bcc3981738cc
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 8 10:02:14 2019 +0200

    ESLint

commit 519d17fc486072813a043e8ba8b96e4651b3bcc5
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 17:53:41 2019 +0200

    Refactor fixed scroll listener, remove `that` pattern

commit 5bfe7f52e04cea0914af74b46fbf5d2074730c30
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 17:01:01 2019 +0200

    Integrate vaadin-tabs resize listener

commit 0d368f2f356c554bed3fa2405210b8d8fd396348
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 16:34:20 2019 +0200

    Refactor context menu dropdown icon vs menu item spacing

commit 3590baf34cebc2f69b9b6291474381e66c52c1e3
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 16:44:41 2019 +0200

    Align Search menu item template with general context menu items population strategy

commit 409aed9bb159454b5f09702970cc635bda9a36c2
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Nov 7 12:13:02 2019 +0200

    Search menu item's full box should trigger context menu

commit 16192b015834e3ead778279574571d95ed8597f5
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 14:59:11 2019 +0200

    CSS class configuration for split nav menu item

commit 4f099e1d313bb1cf62d8835c637a3dccf606d7eb
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 14:39:55 2019 +0200

    CXLMarketingNavElement.contextMenuItems property and configuration engine

commit f30db212e2ac82c63459a136d4e7f08b9085281d
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 13:00:20 2019 +0200

    Move utility <nav> wrap to shadow DOM

commit 6348064310227f1eca39b99ad08c783060e6260a
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Nov 5 11:14:31 2019 +0200

    Refactor cxl-marketing-nav

commit 9a5932738a636bd2bf4e091de4779dd3e7ac8ccd
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:33:50 2019 +0200

    Integrated search box menu item

    @todo search input fails to take Space, Enter keydown [1]

    1: vaadin/vaadin-context-menu#231 (comment)

commit fa209831dade6884c0437d979dd104fa6542f6b3
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:43:40 2019 +0200

    Match simple menu items HTML whitespace w/ complex

commit 989ae01e19b2ff2a6d1f19fc767db6c938238e47
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:42:40 2019 +0200

    Improve team invite menu item spacing

commit fca1edebc911f7f1a3bf6eefe04ae0c251dd158e
Author: Leho Kraav <leho@kraav.com>
Date:   Sun Nov 3 17:44:32 2019 +0200

    Add logo menu item dropdown

commit cd9747da800bea2569ce31bec97a58ff57f9b4f2
Author: Leho Kraav <leho@kraav.com>
Date:   Fri Nov 1 10:10:56 2019 +0200

    Match `resizeVaadinTabs()` wide width w/ vaadin-context-menu [1]

    1: https://github.com/vaadin/vaadin-context-menu/issues/253

commit f6584d21e00664683285975184fbea43653870bb
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 19:25:22 2019 +0200

    Upgrade to @vaadin/vaadin-context-menu-4.3.12

    Ran into duplicate packages: "Custom element already defined"

    ```
    $ yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-context-menu
    $ yarn-deduplicate
    $ yarn
    ```

commit dbfbe243cd3e5369e61365f90f08abd1bed672fb
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 19:22:17 2019 +0200

    Make narrow viewport menu horizontal scroll icons visible

commit 88f8572ced8f8c4cdfba20f3cc9ca9bddd93ac18
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 16:20:49 2019 +0200

    Force vaadin-tab slotted links hover text-underline [1]

    `yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-tabs`
    helped acquire @vaadin/vaadin-themable-mixin-1.5.0+ [2]

    1: vaadin/vaadin-tabs#134 (comment)
    2: https://github.com/vaadin/vaadin-themable-mixin/releases/tag/v1.5.0

commit cb678593820364c17f02323c8401488c3720d831
Author: Leho Kraav <leho@kraav.com>
Date:   Thu Oct 31 15:14:20 2019 +0200

    Menu background color --lumo-black

    * Refactor cxl:logo SVG icon, 24px height
    * Add matching cxl:logo[theme=dark] icon
    * Avoid cxl-marketing-nav element margin collapse

commit a3533b5174c29a1db8e6312735695e4547d9b99b
Author: Leho Kraav <leho@kraav.com>
Date:   Wed Oct 30 21:28:39 2019 +0200

    Partially revert 5cbc1b6, re-simplify story tree structure

commit e7dbdb8411b8772a0fabb4d494911ac122121f01
Author: Leho Kraav <leho@kraav.com>
Date:   Wed Oct 30 21:15:56 2019 +0200

    Increase dropdown icon hover visual prominence

commit c2a5143f8e36c99b0e798055244f1398765f8c60
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 19:06:52 2019 +0200

    Make vaadin-tabs orientation respond to window resize

commit cf280c9537e49f8ccad2d1a38d8f78050d0f79e1
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 18:37:51 2019 +0200

    Horizontal split navigation pattern

commit d84596c07b3106951f368df5b03793774ae87f6a
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 18:37:21 2019 +0200

    Add CXL logo menu item

commit 4ada5e545a23cf1ec77ffc750433adf50ae70a62
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 17:20:26 2019 +0200

    Context menu should open on "click" event

commit 857c4bb33f31f09f726ca97912361b800c54b6e7
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 16:57:03 2019 +0200

    Wrap vaadin-tabs in semantic nav element

commit 141b3532468078dc9c8a611ce534d9dd427bad46
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 16:37:16 2019 +0200

    Move context menu trigger outside menu item link

commit 055d2e80c85ac82da2c185e3406b654107146061
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 16:27:59 2019 +0200

    Prototype links inside vaadin-context-menu

commit c8280c72f09ba4c2b98f6a5a2dbb2935b0b3ad49
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 15:46:35 2019 +0200

    Many more contextMenuItems

commit 9b57508ea38f60a478e22ed81abb2bf3142d34fa
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 08:57:00 2019 +0200

    Nav container element (currently unknown) defaults to `display: inline`, we need `block`

commit 4583f1729587ad14f340ea7f0cc3d2f52d334b9a
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 08:06:11 2019 +0200

    Add links, drop unnecessary menu-item-depth classes

commit eab7f786b851f2a7f7bdbe6623e60dc3a7761af7
Author: Leho Kraav <leho@kraav.com>
Date:   Tue Oct 29 08:04:27 2019 +0200

    Eliminate viewport vertical scrollbar

commit 5cbc1b6367cee0929756a33e6464f2ec630ac4b9
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Oct 28 23:09:12 2019 +0200

    Storybook CSF format

commit 20dc156026eed03b9cb3df0b76bb663713cd9503
Author: Leho Kraav <leho@kraav.com>
Date:   Mon Oct 28 16:45:27 2019 +0200

    Wip cxl-marketing-nav v2 prototype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
vaadin-core
  
✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants