Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aria role for calendar dates #610

Merged
merged 1 commit into from Nov 14, 2018
Merged

Fix aria role for calendar dates #610

merged 1 commit into from Nov 14, 2018

Conversation

samiheikki
Copy link
Contributor

@samiheikki samiheikki commented Sep 30, 2018 •
edited by manolo

limonte
limonte reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this fix?

@samiheikki
Copy link
Contributor Author

Not sure but I'll take a look

@samiheikki samiheikki force-pushed the fix/calendar-a11y branch 2 times, most recently from 2cf370b to 9f579a6 Compare October 20, 2018 09:33
samiheikki
samiheikki commented Oct 20, 2018
View reviewed changes
Copy link
Contributor Author

@samiheikki samiheikki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@samiheikki samiheikki self-assigned this Oct 20, 2018
pekam
pekam approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@pekam pekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @samiheikki)

@pekam pekam merged commit 13772ce into master Nov 14, 2018
@pekam pekam removed the in progress label Nov 14, 2018
@pekam pekam deleted the fix/calendar-a11y branch November 14, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonte limonte limonte left review comments

@pekam pekam pekam approved these changes

Assignees

@samiheikki samiheikki

@pekam pekam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samiheikki @limonte @pekam @tomivirkki @upstairlounge