Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #654 last day of month wrongly disabled #655

Merged
merged 1 commit into from
May 16, 2019

Conversation

danners
Copy link
Contributor

@danners danners commented Apr 30, 2019

  • setDate(-1) sets the date to two days previous, not one

see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setDate#Description


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2019

CLA assistant check
All committers have signed the CLA.

@danners danners closed this May 7, 2019
@danners danners reopened this May 7, 2019
@tomivirkki tomivirkki changed the base branch from master to fix-month-last-date May 16, 2019 08:50
Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lgtm

@tomivirkki tomivirkki merged commit f371f8f into vaadin:fix-month-last-date May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants