Fix enter error before overlay initalized and overlay opening on clear-button click #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overlay should not be opened when clicking the clear-button. This functionality broke with a failing test case after text-field 2.4 update, which fires an input-event on clear-button click. Since we don't know if the input-event was fired from a clear-button click or keyboard-input, the opening is prevented every time when the input value is empty. As a tradeoff, this causes a rare issue: When the input is focused, overlay is not opened and the input is cleared with a single keypress, the overlay is not opened.
tomivirkki
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two fixes in two commits
This change is