Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3 preview #9

Merged
merged 20 commits into from
Jun 20, 2018
Merged

P3 preview #9

merged 20 commits into from
Jun 20, 2018

Conversation

manolo
Copy link
Member

@manolo manolo commented Jun 20, 2018

@manolo manolo force-pushed the p3-preview branch 4 times, most recently from b56cebb to ee59660 Compare June 20, 2018 11:18
@tomivirkki
Copy link
Member

bower.json, line 25 at r6 (raw file):

  ],
  "dependencies": {
    "polymer": "Polymer/polymer#5f5d2c2",

This shouldn't change


Comments from Reviewable

@manolo
Copy link
Member Author

manolo commented Jun 20, 2018

Review status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @tomivirkki)


bower.json, line 25 at r6 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

This shouldn't change

Done.


Comments from Reviewable

@tomivirkki
Copy link
Member

:lgtm:


Reviewed 2 of 7 files at r2, 4 of 6 files at r6, 2 of 2 files at r7.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@tomivirkki tomivirkki merged commit 090b42d into master Jun 20, 2018
@tomivirkki tomivirkki deleted the p3-preview branch June 20, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants