-
Notifications
You must be signed in to change notification settings - Fork 5
WIP: convert to use ES modules, setup unit tests with karma #182
Conversation
e4544ef
to
83890f8
Compare
83890f8
to
02f5ad6
Compare
c686766
to
0dbbaf8
Compare
Any reason not to use btw
It's not a wise practice to just ignore them. |
Review feedback addressed. For now moving back to "Design & discussion" as agreed. The topics left out of the initial scope are:
|
If you are going to use eslint and lit elements, might want to check out adding eslint-plugin-lit to the babel parser plugins list. has a decent collection of rules to help with LitElement linting. |
@moderndeveloperllc yes, Vaadin platform 15 will drop IE11 support and in practice that means that next major versions for all our components will not be tested against it anymore. |
Closing in favor of #207 which contains a rebased and squashed version of this PR. |
Connected to vaadin/components-team-tasks#424
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)