Skip to content
This repository has been archived by the owner on Aug 22, 2021. It is now read-only.

WIP: convert to use ES modules, setup unit tests with karma #182

Closed
wants to merge 12 commits into from

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Nov 27, 2018

Connected to vaadin/components-team-tasks#424


This change is Reviewable

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@limonte limonte mentioned this pull request Dec 3, 2018
@limonte
Copy link
Contributor

limonte commented Dec 5, 2018

Any reason not to use yarn.lock? There are more than 2 thousands of dev-deps and the recent accident with event-stream package demonstrated why lock files are important, read more: https://schneid.io/blog/event-stream-vulnerability-explained/

btw npm install results with

found 5 vulnerabilities (1 low, 4 high)

It's not a wise practice to just ignore them.

@web-padawan
Copy link
Member Author

web-padawan commented Dec 5, 2018

Review feedback addressed. For now moving back to "Design & discussion" as agreed.

The topics left out of the initial scope are:

@moderndeveloperllc
Copy link

If you are going to use eslint and lit elements, might want to check out adding eslint-plugin-lit to the babel parser plugins list. has a decent collection of rules to help with LitElement linting.

@web-padawan
Copy link
Member Author

@moderndeveloperllc yes, Vaadin platform 15 will drop IE11 support and in practice that means that next major versions for all our components will not be tested against it anymore.

@web-padawan
Copy link
Member Author

Closing in favor of #207 which contains a rebased and squashed version of this PR.

@web-padawan web-padawan closed this Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants