-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[form-layout] Form item label does not align with vaadin-text-field label #1166
Comments
Not sure if this is worth fixing. It probably can’t be fixed so that it works in all possible cases (e.g. when using the small theme for vaadin-text-field), but maybe worth fixing so that the most common use case works as expected? |
I think so. Since the baseline shift in |
We have this problem In Bakery. We need to hide a field when there is a new order and show it when editing the order, but the visual result does not align with other fields in the form, as you can see in the next screenshot when changing the display property: This is the same case here, with the difference that we have a The workaround in Bakery is to set |
Using first item label, instead of `vaadin-form-item` prevents misaligin labels See: https://github.com/vaadin/vaadin-form-layout/issues/63 At the same time make dueDate and dueTime stay in the same line when there is enough room
A similar baseline fix, which is used in
vaadin-text-field
, should be applied for the form item label as well (whenlabelsPosition=='top'
).The text was updated successfully, but these errors were encountered: