Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

fix: delay call to client in scrollToEnd #1062

Merged
merged 4 commits into from
Jul 24, 2020
Merged

fix: delay call to client in scrollToEnd #1062

merged 4 commits into from
Jul 24, 2020

Conversation

DiegoCardoso
Copy link

fix #1048

related with #944 and #1028

@DiegoCardoso
fix: delay call to client in scrollToEnd
ea79d5a 
fix #1048

related with #944 and #1028
@vaadin-bot
Copy link

SonarQube analysis reported 33 issues

  • CRITICAL 2 critical
  • MAJOR 8 major
  • MINOR 20 minor
  • INFO 3 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L2357: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L3089: Define a constant instead of duplicating this literal "direction" 4 times. rule
  3. MAJOR Grid.java#: This file has 1,741 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR Grid.java#L1893: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR Grid.java#L1894: Either log or rethrow this exception. rule
  6. MAJOR Grid.java#L1913: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L2902: Call "Optional#isPresent()" before accessing the value. rule
  8. MAJOR Grid.java#L2912: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L3599: Rename "editor" which hides the field declared at line 1163. rule
  10. MAJOR Grid.java#L4010: Remove this unused method parameter "event". rule

@alvarezguille alvarezguille merged commit dc3e17e into master Jul 24, 2020
@alvarezguille alvarezguille deleted the fix/scroll-to-end branch July 24, 2020 07:28
web-padawan pushed a commit that referenced this pull request Jul 24, 2020
@DiegoCardoso @web-padawan
fix: delay call to client in scrollToEnd (#1062)
f88dfc0 
fixes #1048

related with #944 and #1028
web-padawan pushed a commit that referenced this pull request Jul 24, 2020
@DiegoCardoso @web-padawan
fix: delay call to client in scrollToEnd (#1062)
62d8cd7 
fixes #1048

related with #944 and #1028
web-padawan added a commit that referenced this pull request Jul 24, 2020
@web-padawan @DiegoCardoso
fix: delay call to client in scrollToEnd (#1062) (#1080)
a7953df 
fixes #1048

related with #944 and #1028

Co-authored-by: Diego Cardoso <diego@vaadin.com>
web-padawan added a commit that referenced this pull request Jul 24, 2020
@web-padawan @DiegoCardoso
fix: delay call to client in scrollToEnd (#1062) (#1081)
32863d9 
fixes #1048

related with #944 and #1028

Co-authored-by: Diego Cardoso <diego@vaadin.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alvarezguille alvarezguille alvarezguille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrollTo methods in Grid cause render bugs
3 participants
@DiegoCardoso @vaadin-bot @alvarezguille