Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

fix: delay call to client in scrollToEnd (#1062) #1080

Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix: delay call to client in scrollToEnd (#1062) #1080

merged 1 commit into from
Jul 24, 2020

Conversation

web-padawan
Copy link
Member

Cherry-pick to 4.2 branch

@vaadin-bot
Copy link

SonarQube analysis reported 27 issues

  • CRITICAL 2 critical
  • MAJOR 8 major
  • MINOR 16 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L2327: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L2971: Define a constant instead of duplicating this literal "direction" 4 times. rule
  3. MAJOR Grid.java#: This file has 1,694 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR Grid.java#L1886: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR Grid.java#L1887: Either log or rethrow this exception. rule
  6. MAJOR Grid.java#L1906: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L2784: Call "Optional#isPresent()" before accessing the value. rule
  8. MAJOR Grid.java#L2794: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L3485: Rename "editor" which hides the field declared at line 1156. rule
  10. MAJOR Grid.java#L3895: Remove this unused method parameter "event". rule

@web-padawan web-padawan merged commit a7953df into 4.2 Jul 24, 2020
@web-padawan web-padawan deleted the cp-1062 branch July 24, 2020 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants