Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

docs: Document heightByRows performance implications #919

Merged
merged 2 commits into from
Apr 16, 2020
Merged

docs: Document heightByRows performance implications #919

merged 2 commits into from
Apr 16, 2020

Conversation

tomivirkki
Copy link
Member

Relates to #918

@alvarezguille alvarezguille self-requested a review April 16, 2020 07:59
@vaadin-bot
Copy link

SonarQube analysis reported 74 issues

  • CRITICAL 4 critical
  • MAJOR 24 major
  • MINOR 45 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GridDemo.java#L2253: Make "draggedItems" transient or serializable. rule
  2. CRITICAL GridDemo.java#L2254: Make "draggedItem" transient or serializable. rule
  3. CRITICAL Grid.java#L2327: Remove usage of generic wildcard type. rule
  4. CRITICAL Grid.java#L2971: Define a constant instead of duplicating this literal "direction" 4 times. rule
  5. MAJOR GridDemo.java#: This file has 1,968 lines, which is greater than 750 authorized. Split it into smaller files. rule
  6. MAJOR GridDemo.java#L130: Constructor has 8 parameters, which is greater than 7 authorized. rule
  7. MAJOR GridDemo.java#L255: Define and throw a dedicated exception instead of using a generic one. rule
  8. MAJOR GridDemo.java#L809: Remove this useless assignment to local variable "ageColumn". rule
  9. MAJOR GridDemo.java#L1375: Extract the assignment out of this expression. rule
  10. MAJOR GridDemo.java#L1376: Extract the assignment out of this expression. rule

@alvarezguille alvarezguille merged commit 0c8a6d6 into 4.1 Apr 16, 2020
@alvarezguille alvarezguille deleted the document-height-by-rows-performance-impact branch April 16, 2020 08:37
alvarezguille added a commit that referenced this pull request Apr 16, 2020
@tomivirkki @alvarezguille
docs: Document heightByRows performance implications (#919)
7d0b785 
Co-authored-by: Guille <alvarezguille@users.noreply.github.com>
alvarezguille added a commit that referenced this pull request Apr 16, 2020
@tomivirkki @alvarezguille
docs: Document heightByRows performance implications (#919)
6901e3d 
Co-authored-by: Guille <alvarezguille@users.noreply.github.com>
alvarezguille added a commit that referenced this pull request Apr 16, 2020
@tomivirkki @alvarezguille
docs: Document heightByRows performance implications (#919)
4ba478b 
Co-authored-by: Guille <alvarezguille@users.noreply.github.com>
alvarezguille added a commit that referenced this pull request Apr 16, 2020
@alvarezguille
docs: Document heightByRows performance implications (#919) (#940)
118e15a
alvarezguille added a commit that referenced this pull request Apr 16, 2020
@alvarezguille
docs: Document heightByRows performance implications (#919) (#941)
692849b
alvarezguille added a commit that referenced this pull request Apr 16, 2020
@alvarezguille
docs: Document heightByRows performance implications (#919) (#942)
2e65d34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alvarezguille alvarezguille alvarezguille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomivirkki @vaadin-bot @alvarezguille