Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

docs: Document heightByRows performance implications (#919) #940

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

alvarezguille
Copy link
Member

Co-authored-by: Guille <alvarezguille@users.noreply.github.com>
@vaadin-bot
Copy link

SonarQube analysis reported 74 issues

  • CRITICAL 4 critical
  • MAJOR 23 major
  • MINOR 46 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GridDemo.java#L2249: Make "draggedItems" transient or serializable. rule
  2. CRITICAL GridDemo.java#L2250: Make "draggedItem" transient or serializable. rule
  3. CRITICAL Grid.java#L2320: Remove usage of generic wildcard type. rule
  4. CRITICAL Grid.java#L2964: Define a constant instead of duplicating this literal "direction" 4 times. rule
  5. MAJOR GridDemo.java#: This file has 1,940 lines, which is greater than 750 authorized. Split it into smaller files. rule
  6. MAJOR GridDemo.java#L127: Constructor has 8 parameters, which is greater than 7 authorized. rule
  7. MAJOR GridDemo.java#L252: Define and throw a dedicated exception instead of using a generic one. rule
  8. MAJOR GridDemo.java#L805: Remove this useless assignment to local variable "ageColumn". rule
  9. MAJOR GridDemo.java#L1371: Extract the assignment out of this expression. rule
  10. MAJOR GridDemo.java#L1372: Extract the assignment out of this expression. rule

@alvarezguille alvarezguille merged commit 118e15a into master Apr 16, 2020
@alvarezguille alvarezguille deleted the cp-919-master branch April 16, 2020 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants