Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demos with custom dom modules don't work on IE11 #799

Closed
Saulis opened this issue Mar 13, 2017 · 1 comment
Closed

Demos with custom dom modules don't work on IE11 #799

Saulis opened this issue Mar 13, 2017 · 1 comment
Assignees
@platosha
Milestone
2.0.0-beta1

Comments

@Saulis
Copy link
Contributor

Saulis commented Mar 13, 2017 •
edited by tomivirkki
Loading

Since IE11 uses a polyfill for <template>, any <script> inside a template is run during init.

Demo which include a template containing custom <dom-module> and <script> which calls Polymer({..}) will fail in IE11.

Adding a WebComponentsReady listener should fix this issue.
@Saulis Saulis added the 2.0 label Mar 13, 2017
platosha added a commit that referenced this issue Mar 13, 2017
@platosha
Fix demos to work IE11
919b924 
Fixes #799
@platosha platosha mentioned this issue Mar 13, 2017
Merged
@platosha platosha self-assigned this Mar 13, 2017
@platosha
Copy link
Contributor

Note: In IE11, <demo-snippet>’s code snippet shows <template> contents as empty. This is, probably, due to the <demo-snippet> incompatibility with the <template> polyfill.

The demos work fine, though.

@platosha platosha added this to the 2.0.0-beta1 milestone Mar 16, 2017
HJK181 pushed a commit to CommerceExperts/vaadin-grid that referenced this issue Jul 27, 2020
@pekam
Fix duplicate custom-value-set events fired (vaadin#799)
ecc4d4f 
The _onClosed function was running twice when the overlay was closed:
- once by reacting to the dropdown closing event
- another time by the opened property observer

Because of this, the custom-value-set event was fired twice.

This was not caught by the tests, because the test combo box didn't
have any items, so there was no overlay, which would be closed to make
the extra _onClosed call.

Fix vaadin/vaadin-combo-box-flow#167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@platosha platosha

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta1
Development

No branches or pull requests
2 participants
@platosha @Saulis