Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract title/description to vaadin-login-overlay #48

Merged
merged 9 commits into from
Dec 14, 2018
Merged

Extract title/description to vaadin-login-overlay #48

merged 9 commits into from
Dec 14, 2018

Commits on Dec 14, 2018

  1. Move title/description to vaadin-login-overlay 

    - Make vaadin-login-overlay-element extend vaadin-overlay template
- Move title/description to vaadin-login-overlay
- Remove props from mixin
- Pass through to vloe props set on vaadin-login-overlay
- Move styles to vaadin-login-overlary-element
- Move tests related to title/description

Fix #45
    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    8a4407a View commit details
    Browse the repository at this point in the history

  2. Add title/description props to VLOE

    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    23f90b1 View commit details
    Browse the repository at this point in the history

  3. Extract vaadin-login-overlay-element

    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    19cba78 View commit details
    Browse the repository at this point in the history

  4. Avoid using ::slotted() due IE11 issuess

    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    711135b View commit details
    Browse the repository at this point in the history

  5. Fix review changes request 

    - Fix i18n demo looking
- Fix vaadin-login max-width and background
- Fix inputs focus ring being cropped
    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    8c3bf8d View commit details
    Browse the repository at this point in the history

  6. Remove commented line

    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    978d3e7 View commit details
    Browse the repository at this point in the history

  7. Fix demo for IE11 

    Remove ES6 code from samples
    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    937f201 View commit details
    Browse the repository at this point in the history

  8. Fix review comments 

    - Incorrect indentation
- Remove notify not needed for title/description
    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    d775e60 View commit details
    Browse the repository at this point in the history

  9. Fix license header to Apache 2

    @DiegoCardoso
    DiegoCardoso committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    d4dddd9 View commit details
    Browse the repository at this point in the history