Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract title/description to vaadin-login-overlay #48

Merged
merged 9 commits into from
Dec 14, 2018

Conversation

DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Dec 12, 2018

  • Make vaadin-login-overlay-element extend vaadin-overlay template
  • Move title/description to vaadin-login-overlay
  • Remove props from mixin
  • Pass through to vloe props set on vaadin-login-overlay
  • Move styles to vaadin-login-overlary-element
  • Move tests related to title/description

Fix #45


This change is Reviewable

@coveralls
Copy link

coveralls commented Dec 12, 2018

Pull Request Test Coverage Report for Build 185

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 97.087%

Totals Coverage Status
Change from base Build 183: 0.4%
Covered Lines: 71
Relevant Lines: 71

💛 - Coveralls

Copy link
Contributor

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks.

I only found a few issues with the demos:

  • I18n demo looks ugly. Can we apply the same styles as in the "Basic" version?
  • Should we add a demo with the overlay without full screen? I think it looks much better with the overlay and the full screen version is hidden by default.
  • Full screen demo does not work in IE11.

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DiegoCardoso)


test/login-test.html, line 108 at r1 (raw file):

        login.i18n = i18n;
        expect(additionalInformation.textContent).to.be.equal(login.i18n.additionalInformation);
        // expect(login.title).to.be.equal(login.i18n.additionalInformation);

Can we remove the commented out code?

Copy link
Contributor

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DiegoCardoso)

Copy link
Contributor Author

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @tulioag)


test/login-test.html, line 108 at r1 (raw file):

Previously, tulioag (Tulio Garcia) wrote…

Can we remove the commented out code?

Done.

Copy link
Contributor

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

src/vaadin-login-overlay-element.html Outdated Show resolved Hide resolved
src/vaadin-login-overlay-element.html Outdated Show resolved Hide resolved
src/vaadin-login-overlay.html Show resolved Hide resolved
src/vaadin-login-overlay.html Outdated Show resolved Hide resolved
Copy link
Contributor

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @web-padawan)

Copy link
Contributor

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @web-padawan)

- Make vaadin-login-overlay-element extend vaadin-overlay template
- Move title/description to vaadin-login-overlay
- Remove props from mixin
- Pass through to vloe props set on vaadin-login-overlay
- Move styles to vaadin-login-overlary-element
- Move tests related to title/description

Fix #45
- Fix i18n demo looking
- Fix vaadin-login max-width and background
- Fix inputs focus ring being cropped
Remove ES6 code from samples
- Incorrect indentation
- Remove notify not needed for title/description
Copy link
Contributor Author

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r5.
Dismissed @web-padawan from 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@DiegoCardoso DiegoCardoso merged commit 7ad5e3b into master Dec 14, 2018
@DiegoCardoso DiegoCardoso deleted the feat/45-move-title-and-descrip branch December 14, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants