Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo #49

Merged
merged 1 commit into from Dec 14, 2018
Merged

Fix a typo #49

merged 1 commit into from Dec 14, 2018

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Dec 13, 2018 •
edited by DiegoCardoso

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.667%
Totals Coverage Status
Change from base Build 162: 0.0%
Covered Lines: 60
Relevant Lines: 60
💛 - Coveralls

DiegoCardoso
DiegoCardoso approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks for noticing this 🙇

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@DiegoCardoso DiegoCardoso merged commit 188269f into master Dec 14, 2018
@DiegoCardoso DiegoCardoso deleted the kb/typo-fix branch December 14, 2018 11:04
@DiegoCardoso DiegoCardoso mentioned this pull request Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SomeoneToIgnore @CLAassistant @coveralls @DiegoCardoso