Allow custom html in title

[tulioag]

Closes #10

---

This change is 

[DiegoCardoso]

Nice! We are almost there! 😃

I have some comments bellow and sorry for not being able to review it right away.

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @tulioag and @DiegoCardoso)

---

demo/element-basic-demos.html, line 59 at r1 (raw file):

    <vaadin-demo-snippet id="login-overlay">
      <template preserve-content>
      <vaadin-login-overlay><h1 slot="title">My App</h1></vaadin-login-overlay>

nit: indentation is not correct.

Also, I am wondering whether it makes sense to show this feature here or in another example. It may make more sense to have it in an advanced tab, so we can keep the basic examples simple. What do you think?

---

src/vaadin-login-overlay.html, line 110 at r1 (raw file):

        }

        _createTeleporter() {

Why aren't teleport and unteleport functions declared straight as part of VaadinLoginOverlay? teleported could be a private member of the class, as it makes sense to keep it cached. That way, we wouldn't need to create this for every instance of vaadin-login-overlay.

[coveralls]

Pull Request Test Coverage Report for Build 203

• 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 98.23%

---

Totals
Change from base Build 191:	0.3%
Covered Lines:	81
Relevant Lines:	81

---

💛 - Coveralls

[tulioag]

Reviewable status: 1 of 8 files reviewed, 2 unresolved discussions (waiting on @DiegoCardoso)

---

demo/element-basic-demos.html, line 59 at r1 (raw file):

Previously, DiegoCardoso (Diego Cardoso) wrote…

nit: indentation is not correct.

Also, I am wondering whether it makes sense to show this feature here or in another example. It may make more sense to have it in an advanced tab, so we can keep the basic examples simple. What do you think?

Agreed. Done.

---

src/vaadin-login-overlay.html, line 110 at r1 (raw file):

Previously, DiegoCardoso (Diego Cardoso) wrote…

Why aren't teleport and unteleport functions declared straight as part of VaadinLoginOverlay? teleported could be a private member of the class, as it makes sense to keep it cached. That way, we wouldn't need to create this for every instance of vaadin-login-overlay.

The idea was to group the functionality in one opaque object. I refactored this so now the _teleport function just returns a function to undo the teleport. Besides that, I added caching for the query .

[tulioag]

Reviewable status: 1 of 8 files reviewed, 1 unresolved discussion (waiting on @DiegoCardoso)

---

src/vaadin-login-overlay.html, line 110 at r1 (raw file):

Previously, tulioag (Tulio Garcia) wrote…

The idea was to group the functionality in one opaque object. I refactored this so now the _teleport function just returns a function to undo the teleport. Besides that, I added caching for the query .

Done.

[alexberazouski]

Reviewed 2 of 3 files at r2, 4 of 5 files at r3.
Reviewable status: 6 of 8 files reviewed, 2 unresolved discussions (waiting on @alexberazouski, @DiegoCardoso, and @tulioag)

---

demo/advanced-demos.html, line 12 at r3 (raw file):

    <vaadin-demo-snippet id="login-overlay">
      <template preserve-content>
        <vaadin-login-overlay><h1 slot="title"><iron-icon icon="vaadin:vaadin-h"></iron-icon> My App</h1></vaadin-login-overlay>

nitpick: Icon and text are misaligned