Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes after merging #51 #53

Merged
merged 3 commits into from
Dec 18, 2018

Conversation

tulioag
Copy link
Contributor

@tulioag tulioag commented Dec 18, 2018

  • Improved appearance advanced demo
  • Updated test to check if the title elements can be teleported a second time

This change is Reviewable

@coveralls
Copy link

coveralls commented Dec 18, 2018

Pull Request Test Coverage Report for Build 209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.23%

Totals Coverage Status
Change from base Build 204: 0.0%
Covered Lines: 81
Relevant Lines: 81

💛 - Coveralls

Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @tulioag)


demo/index.html, line 26 at r1 (raw file):

    <style include="vaadin-component-demo-shared-styles"></style>
  </custom-style>
  <style>

This looks like a wrong place to style the element. Apparently the teleportation doesn't copy the styles

Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tulioag)

Copy link
Contributor Author

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alexberazouski)


demo/index.html, line 26 at r1 (raw file):

Previously, alexberazouski wrote…

This looks like a wrong place to style the element. Apparently the teleportation doesn't copy the styles

It would only work anyway if the element was placed n the shadow dom. Maybe it would work with slotted?

Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@alexberazouski alexberazouski merged commit 2314d58 into master Dec 18, 2018
@alexberazouski alexberazouski deleted the fix/improve-appearance-advanced-demo branch December 18, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants