-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material theme tabs #22
Conversation
Reviewed 5 of 6 files at r1. a discussion (no related file): Right now, I can hardly see when a tab is focused. The same issue exists with The Guideline does not specify explicitly how tab focus and hover look too, unfortunately. Not a part of the scope maybe, so this is not a blocker issue. Just an enhancement idea. IMO, would be nice to have hover and focus highlight the way Material Components Tabs have them. a discussion (no related file): The Guidelines examples, a discussion (no related file): Actual: wrapped tab text is aligned to the left a discussion (no related file): Actual: In fact, the Guideline specifically defines two distinct types of tabs: fixed tabs and scrollable tabs. We could have one type as default behavior, and another as a theme variation. Since it’s not expected to adjust theme to enable scrolling, I would suggest that “scrollable” is a default look, and there is also an opt-in a discussion (no related file): Actual: there is a gap between the tabs container edge and the first tab edge: vaadin-tab.html, line 16 at r1 (raw file):
vaadin-tabs.html, line 135 at r1 (raw file):
Missing demo for the Comments from Reviewable |
Reviewed 1 of 6 files at r1. Comments from Reviewable |
Review status: 3 of 6 files reviewed at latest revision, 8 unresolved discussions. vaadin-tabs.html, line 91 at r2 (raw file):
Need to wrap this property (currently supported without prefix by Firefox only) into the condition to prevent Edge crash. Example: https://github.com/vaadin/vaadin-tabs/blob/master/theme/lumo/vaadin-tabs.html#L81 Comments from Reviewable |
Merged in 02c8321 |
Note: Using valo-icons still instead of material icons. Icons will be updated later
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)