fix: overflow feature now works correctly when menu-bar has "min-width: 0". #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Fixes #130 |
The menubar is now inside a container and tests do resizing of the container instead of the menubar itself. Add a new test to check fix for the menubar not growing back on resizing (#130).
tomivirkki
reviewed
Feb 1, 2021
check if the overflow button is hidden after changing the items array of the menubar
tomivirkki
approved these changes
Feb 3, 2021
sosa-vaadin
added a commit
that referenced
this pull request
Feb 8, 2021
…h: 0". (CP: #134) (#135) add a new test to check fix for the menu-bar not growing back on resizing (#130). * add new fixture and test check if the overflow button is hidden after changing the items array of the menubar Co-authored-by: web-padawan <iamkulykov@gmail.com> * fix: revert changes needed for Polymer 2 Co-authored-by: web-padawan <iamkulykov@gmail.com> Co-authored-by: David Sosa <sosa@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The __detectOverflow method was changed. It will now reset visibility of all buttons and then hide any buttons that are overflowing, adding them to the "overflow" button.
Fixes #130
Fixes #133