fix: overflow feature now works correctly when menu-bar has "min-width: 0". (CP: #134) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
requested changes
Feb 3, 2021
| @@ -234,7 +224,7 @@ | |||
|
|
|||
| /** @private */ | |||
| __alignOverlayPosition(e) { | |||
| /* istanbul ignore if */ | |||
| /* c8 ignore next */ | |||
There was a problem hiding this comment.
Please revert this change, it was needed because @web/test-runner is using a different tool for coverage.
tomivirkki
reviewed
Feb 3, 2021
tomivirkki
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for #134
add a new test to check fix for the menubar not growing back on resizing (#130).
check if the overflow button is hidden after changing the items array of the menubar
Co-authored-by: web-padawan iamkulykov@gmail.com