Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LitElement conversion part 3: theme and visual tests #140

Merged
merged 3 commits into from
Mar 27, 2020

Conversation

web-padawan
Copy link
Member

Fixes #135

Submitting this now, to make it easier to play with component while reviewing #139

Will be rebased after that PR is merged.

Copy link
Contributor

@Haprog Haprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue and one additional improvement suggestion.

theme/lumo/vaadin-split-layout-css.ts Outdated Show resolved Hide resolved
theme/material/vaadin-split-layout-styles.ts Outdated Show resolved Hide resolved
@web-padawan web-padawan marked this pull request as ready for review March 27, 2020 14:30
@web-padawan web-padawan merged commit 7c29fff into next-prepare Mar 27, 2020
@web-padawan web-padawan deleted the next-theme branch March 27, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants