Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests: Enable IE11, bump iOS version #71

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Conversation

platosha
Copy link
Contributor

@platosha platosha commented May 29, 2017

Fixes #70


This change is Reviewable

@samiheikki
Copy link
Contributor

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


wct.conf.js, line 12 at r1 (raw file):

      // iPad simulator does not start on Saucelabs for some reason
      // TODO: enable back
      // 'macOS 10.12/ipad@10.3',

Any reason why the ipad simulator not starting? Was with working with the 9.3 version?


Comments from Reviewable

Copy link
Contributor

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build time is drastically increased.

Before:

After:

Also, the build isn't stable anymore because of iphone 10.3 instability.

@platosha
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


wct.conf.js, line 12 at r1 (raw file):

Previously, samiheikki (Sami Suo-Heikki) wrote…

Any reason why the ipad simulator not starting? Was with working with the 9.3 version?

Was working, does not work anymore after the order of scripts changed in test/index.html.

iPhone 10.3 works fine, iPad 10.3 does not start at all. I guess, the iPad Simulator of this newest version is just not ready in SauceLabs VMs yet.


Comments from Reviewable

@platosha
Copy link
Contributor Author

platosha commented May 30, 2017

@limonte true that, but the simulator startup on SauceLabs is not under our control. The total build time here is still okay though.

We should migrate to newer iOS on CI at some point anyway. Having IE11 and modern iOS tests enabled is more relevant than iOS 9.

@limonte limonte dismissed their stale review May 30, 2017 07:52

True that.

@manolo
Copy link
Member

manolo commented May 30, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion.


wct.conf.js, line 12 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

Was working, does not work anymore after the order of scripts changed in test/index.html.

iPhone 10.3 works fine, iPad 10.3 does not start at all. I guess, the iPad Simulator of this newest version is just not ready in SauceLabs VMs yet.

Can you try 'OS X 10.11/ipad@10.2' instead, it works in other elements


Comments from Reviewable

@platosha
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


wct.conf.js, line 12 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

Can you try 'OS X 10.11/ipad@10.2' instead, it works in other elements

It does not work here, mock-interactions.js touch events + the polyfill do not work nicely in iOS 10.2.

I mean, the element itself works fine, but the dynamic tests for dragging the splitter will get errors.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Jun 1, 2017

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@samiheikki
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@samiheikki samiheikki merged commit ea019eb into master Jun 1, 2017
@samiheikki samiheikki deleted the fix/enable-ie11-tests branch June 1, 2017 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants