-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI tests: Enable IE11, bump iOS version #71
Conversation
Reviewed 2 of 2 files at r1. wct.conf.js, line 12 at r1 (raw file):
Any reason why the ipad simulator not starting? Was with working with the 9.3 version? Comments from Reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review status: all files reviewed at latest revision, 1 unresolved discussion. wct.conf.js, line 12 at r1 (raw file): Previously, samiheikki (Sami Suo-Heikki) wrote…
Was working, does not work anymore after the order of scripts changed in iPhone 10.3 works fine, iPad 10.3 does not start at all. I guess, the iPad Simulator of this newest version is just not ready in SauceLabs VMs yet. Comments from Reviewable |
@limonte true that, but the simulator startup on SauceLabs is not under our control. The total build time here is still okay though. We should migrate to newer iOS on CI at some point anyway. Having IE11 and modern iOS tests enabled is more relevant than iOS 9. |
Review status: all files reviewed at latest revision, 1 unresolved discussion. wct.conf.js, line 12 at r1 (raw file): Previously, platosha (Anton Platonov) wrote…
Can you try 'OS X 10.11/ipad@10.2' instead, it works in other elements Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. wct.conf.js, line 12 at r1 (raw file): Previously, manolo (Manuel Carrasco Moñino) wrote…
It does not work here, mock-interactions.js touch events + the polyfill do not work nicely in iOS 10.2. I mean, the element itself works fine, but the dynamic tests for dragging the splitter will get errors. Comments from Reviewable |
Reviewed 2 of 2 files at r1. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Fixes #70
This change is