Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visual tests #62

Merged
merged 3 commits into from
Jun 27, 2018
Merged

Update visual tests #62

merged 3 commits into from
Jun 27, 2018

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jun 27, 2018

Visual tests configs were included during the alignment PR #61 . This PR is actually adding tests and fixing errors with the CI build.
Connected to #57


This change is Reviewable

@tomivirkki
Copy link
Member

.travis.yml, line 21 at r1 (raw file):

script:
  - if [[ "$POLYMER" = "2" ]]; then
      npm -q i && npm i -q --no-save bower polymer-cli wct-istanbul && bower -q i &&

None of the other components have this. Why make this an exception? Seems like the following is missing https://github.com/vaadin/vaadin-element-skeleton/blob/master/wct.conf.js#L7


Comments from Reviewable

@yuriy-fix
Copy link
Contributor Author

Review status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @YuriyVaadin)


.travis.yml, line 21 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

None of the other components have this. Why make this an exception? Seems like the following is missing https://github.com/vaadin/vaadin-element-skeleton/blob/master/wct.conf.js#L7

Updated. Thanks!


Comments from Reviewable

@tomivirkki
Copy link
Member

:lgtm:


Reviewed 10 of 12 files at r1, 2 of 2 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@tomivirkki tomivirkki merged commit 1c9244c into master Jun 27, 2018
@tomivirkki tomivirkki deleted the visual-tests branch June 27, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants