Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Install polymer-cli locally, set code coverage threshold to 98 #57

Closed
wants to merge 3 commits into from

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Jun 14, 2018

Trying to get the build green...


This change is Reviewable

@limonte limonte force-pushed the test/wct-polymer-test branch 3 times, most recently from 416a6f1 to 22bfb7e Compare June 14, 2018 09:18
@limonte limonte changed the title Install wct-instanbul globally, set code coverage threshold to 98 [WIP] Install wct-instanbul globally, set code coverage threshold to 98 Jun 14, 2018
@limonte limonte changed the title [WIP] Install wct-instanbul globally, set code coverage threshold to 98 [WIP] Install polymer-cli locally, set code coverage threshold to 98 Jun 14, 2018
@manolo
Copy link
Member

manolo commented Jun 14, 2018

Review status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @limonte)


.travis.yml, line 15 at r1 (raw file):

before_script:
  - npm install -g bower polymer-cli@next

what is the main reason of this ?


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Jun 15, 2018

Review status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @limonte)


.travis.yml, line 15 at r2 (raw file):

before_script:
  - npm install bower polymer-cli@next

you need to ad --no-save in all npm calls so as P3 modulizer does not fail


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Jun 15, 2018

Review status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @limonte)


.travis.yml, line 15 at r2 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

you need to ad --no-save in all npm calls so as P3 modulizer does not fail

I think for this component you might take the .travis.yml from a p3-preview of any element, for instance vaadin-item


Comments from Reviewable

@yuriy-fix yuriy-fix self-assigned this Jun 21, 2018
@yuriy-fix yuriy-fix mentioned this pull request Jun 27, 2018
@yuriy-fix
Copy link
Contributor

Closed as changes were applied on master and #62.

@yuriy-fix yuriy-fix closed this Jun 27, 2018
@web-padawan web-padawan deleted the test/wct-polymer-test branch March 30, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants