refactor: use overlay-position-mixin with context-menu and menu-bar #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Nov 2, 2021
web-padawan
requested changes
Nov 3, 2021
There was a problem hiding this comment.
Some comments on the code expanding the ideas by @sissbruecker. I still have yet to test context-menu and menu-bar manually, maybe then I will have more ideas.
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Nov 5, 2021
|
This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the planned overlay positioning refactor by removing internal logic from
<vaadin-context-menu>and<vaadin-menu-bar>in favour of using thevaadin-overlay-position-mixin.The change not only cleans up the codebase but also makes (re)positioning of nested menus more fluent and stable:
Before:
menu-overlay-positioning-before.mp4
After:
menu-overlay-positioning-after.mp4
Related #2497, #2510 and #2567