Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use overlay-position-mixin with combo-box #2497

Merged
merged 15 commits into from
Sep 11, 2021
Merged

refactor: use overlay-position-mixin with combo-box #2497

merged 15 commits into from
Sep 11, 2021

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Sep 10, 2021 •
edited by web-padawan
Loading

Removes a lot of the internal overlay positioning logic from <vaadin-combo-box> in favour of using the vaadin-overlay-position-mixin.

Fixes #1353

@tomivirkki tomivirkki marked this pull request as draft September 10, 2021 09:19
web-padawan
web-padawan reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also remove dedicated outsideClickListener and instead update vaadin-combo-box-overlay to override the corresponding method from vaadin-overlay?

web-components/packages/vaadin-overlay/src/vaadin-overlay.js

Line 496 in 6ce151b

_outsideClickListener(event) {

@tomivirkki tomivirkki force-pushed the combo-box-overlay-position-mixin branch from d5b2f4c to e9047f7 Compare September 10, 2021 14:30
@tomivirkki tomivirkki force-pushed the combo-box-overlay-position-mixin branch from 0f9b794 to 9b3fc0d Compare September 10, 2021 17:04
@tomivirkki tomivirkki marked this pull request as ready for review September 10, 2021 17:17
web-padawan
web-padawan reviewed Sep 11, 2021
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments, will take a closer look later and test the actual behavior.

packages/vaadin-combo-box/test/dynamic-size.test.js Outdated Show resolved Hide resolved
packages/vaadin-combo-box/test/dynamic-size.test.js Outdated Show resolved Hide resolved
packages/vaadin-combo-box/test/lazy-loading.test.js Outdated Show resolved Hide resolved
packages/vaadin-combo-box/test/lazy-loading.test.js Outdated Show resolved Hide resolved
packages/vaadin-combo-box/test/overlay-position.test.js Outdated Show resolved Hide resolved
packages/vaadin-combo-box/test/overlay-position.test.js Outdated Show resolved Hide resolved
packages/vaadin-combo-box/test/overlay-position.test.js Outdated Show resolved Hide resolved
packages/vaadin-overlay/src/vaadin-overlay-position-mixin.js Show resolved Hide resolved
packages/vaadin-overlay/src/vaadin-overlay-position-mixin.js Outdated Show resolved Hide resolved
web-padawan
web-padawan approved these changes Sep 11, 2021
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in desktop Chrome, Safari, Firefox, iOS Simulator 14.5 and Android Chrome.
Everything works fine, page scroll and virtual keyboard are handled properly 💯

Left a few non-blocking comments but overall LGTM 👍

packages/vaadin-overlay/src/vaadin-overlay-position-mixin.js Show resolved Hide resolved
packages/vaadin-combo-box/src/vaadin-combo-box-dropdown.js Outdated Show resolved Hide resolved
packages/vaadin-overlay/src/vaadin-overlay-position-mixin.js Outdated Show resolved Hide resolved
tomivirkki and others added 2 commits September 11, 2021 18:34
@tomivirkki @web-padawan
Update packages/vaadin-overlay/src/vaadin-overlay-position-mixin.js
6f86306 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@tomivirkki @web-padawan
Update packages/vaadin-overlay/src/vaadin-overlay-position-mixin.js
cf36999 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki merged commit d81e89e into master Sep 11, 2021
@tomivirkki tomivirkki deleted the combo-box-overlay-position-mixin branch September 11, 2021 15:46
@tomivirkki tomivirkki mentioned this pull request Sep 11, 2021
Merged
@web-padawan web-padawan mentioned this pull request Sep 11, 2021
Closed
7 tasks
@tomivirkki tomivirkki mentioned this pull request Sep 17, 2021
Merged
This was referenced Sep 18, 2021
Closed
Closed
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

@tomivirkki tomivirkki mentioned this pull request Oct 23, 2021
Merged
@sissbruecker sissbruecker mentioned this pull request Nov 25, 2021
Merged
1 task
@tomivirkki tomivirkki mentioned this pull request Dec 15, 2021
Merged
@web-padawan web-padawan mentioned this pull request May 27, 2022
Merged
@web-padawan web-padawan mentioned this pull request Jul 8, 2022
Merged
@web-padawan web-padawan mentioned this pull request Dec 29, 2023
Merged
@web-padawan web-padawan mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[combo-box] Cleanup obsolete code already present in depended components/mixins
3 participants
@tomivirkki @vaadin-bot @web-padawan