fix: Refactor vaadin-text-area Material styles #3241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
requested changes
Dec 30, 2021
Comment on lines
+34
to
+35
| .vaadin-text-area-container::before, | ||
| .vaadin-text-area-container::after { |
There was a problem hiding this comment.
We should not use internal parts in themes.
There was a problem hiding this comment.
I am just voting for pragmatism here
|
Just note. Some visual tests break as this change grows the undefined height field by 2px as the underline is growing "outside". However with these styles it looks good and field with fixed height looks good. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing in favor of #3359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1333 for Vaadin 22