-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: position the material text-area bottom bar #3359
Conversation
054b0b2
to
1cd8bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. When removing max-height
set on the element, scrollbar does not go away automatically. This is an edge case so we can probably address it later (it will probably require using ResizeObserver
).
scroll.mp4
.
Kudos, SonarCloud Quality Gate passed!
|
Good catch. There was a unit test for resizing but this bug turned out to be theme-specific. Added ResizeMixin as suggested and now it works as expected. |
Hi @tomivirkki , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
Fixes #1333
Closes #3241
The fix is inspired by #1333 (comment)
There's now a private CSS variable named
--_text-area-vertical-scroll-position
which is kept in sync with the scrollTop of the input field. It's used for adjusting the position of the pseudo-elements used in MD for the bottom bar.