refactor!: update month calendar to use table #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Jan 31, 2022
Comment on lines
+405
to
+409
| if (this.__isDayFocused(date, focusedDate)) { | ||
| return '0'; | ||
| } | ||
|
|
||
| return '-1'; |
There was a problem hiding this comment.
nit: untested (ignore, in case the tests are to be added with the following refactors)
There was a problem hiding this comment.
Thanks. I will enhance keyboard navigation tests in the next PR.
Comment on lines
+292
to
+296
| if (days.some((date) => dateEquals(date, focusedDate))) { | ||
| this.removeAttribute('aria-hidden'); | ||
| } else { | ||
| this.setAttribute('aria-hidden', 'true'); | ||
| } |
There was a problem hiding this comment.
nit: untested (ignore, in case the tests are to be added with the following refactors)
There was a problem hiding this comment.
Will cover this in the next PR as well.
This was referenced Feb 3, 2022
|
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
This was referenced Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first step of
vaadin-date-pickeroverlay content a11y improvements.Changed to use
<table>markup. For now the focus is not yet changed.The next step would be to use
<button>in table cells like in Duet Date Picker.Related to #3248
Type of change