-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: update month calendar to use table #3355
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
if (this.__isDayFocused(date, focusedDate)) { | ||
return '0'; | ||
} | ||
|
||
return '-1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: untested (ignore, in case the tests are to be added with the following refactors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will enhance keyboard navigation tests in the next PR.
if (days.some((date) => dateEquals(date, focusedDate))) { | ||
this.removeAttribute('aria-hidden'); | ||
} else { | ||
this.setAttribute('aria-hidden', 'true'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: untested (ignore, in case the tests are to be added with the following refactors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will cover this in the next PR as well.
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
Description
This is a first step of
vaadin-date-picker
overlay content a11y improvements.Changed to use
<table>
markup. For now the focus is not yet changed.The next step would be to use
<button>
in table cells like in Duet Date Picker.Related to #3248
Type of change