refactor: remove unused code from date-picker #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
commented
Oct 23, 2022
Comment on lines
-13
to
-16
| :host([dir='rtl']) [part='value']::placeholder { | ||
| direction: rtl; | ||
| text-align: left; | ||
| } |
There was a problem hiding this comment.
These styles are no longer used since #2532 where we changed to use slotted <input> element.
Comment on lines
-432
to
-436
| __getWeekNumbers(dates) { | ||
| return dates | ||
| .map((date) => this.__getWeekNumber(date, dates)) | ||
| .filter((week, index, arr) => arr.indexOf(week) === index); | ||
| } |
There was a problem hiding this comment.
This method is no longer used since #3355 where we changed how week numbers are rendered.
vursen
approved these changes
Oct 23, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 23, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 23, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed some no longer used code from the date-picker.
Type of change