feat: announce file upload events #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
10 tasks
tomivirkki
commented
Feb 3, 2022
Comment on lines
+181
to
+184
| expect(scrollTarget.getBoundingClientRect().bottom).to.be.within( | ||
| Math.round(itemRect.top), | ||
| Math.round(itemRect.bottom) | ||
| ); |
There was a problem hiding this comment.
Not related to the change, but these tests have started failing (on master) due to some sub-pixel rendering change.
web-padawan
approved these changes
Feb 3, 2022
tomivirkki
changed the title
|
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3365
This PR makes the
<vaadin-upload>component announce on the following file upload eventsWhen the events occur, focus doesn't leave the "upload files" button but instead, an alert is created using the internal
a11y-announcerhelper. The PR also adds support formode: 'alert'toa11y-announcer.Testing tip: the upload dev page has a radio group for switching the outcome of a manual file upload.