refactor: remove unused code from time-picker #3690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code was introduced in #2618 and appears to be a copy-paste from
vaadin-combo-box-light
component.The
_onChange
override is not needed because the clear button click is handled inComboBoxMixin
:web-components/packages/combo-box/src/vaadin-combo-box-mixin.js
Lines 416 to 418 in 9b9fa8a
Also
_isClearButton()
override isn't needed because in case of time-picker we can be sure thatclearElement
exists by the time when the component is initialised, andthis.querySelector('[part="clear-button"]')
returns a reference to it.Type of change