refactor: override internal elements in time-picker #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/time-picker-tag-name
branch
from
8a23139
to
e277867
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Sep 24, 2021
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the implementation to make
vaadin-time-pickeruse own tag names for internal elements:vaddin-time-picker-dropdownvaddin-time-picker-overlayvaadin-time-picker-scrollervaadin-time-picker-itemThis also removes
ComboBoxDataProviderMixinwhich we don't really need in time-picker.Type of change