test: extract validation tests, improve test coverage #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
test/number-field/extract-validation-tests
branch
3 times, most recently
from
e289f05
to
561f905
Compare
vursen
force-pushed
the
test/number-field/extract-validation-tests
branch
from
561f905
to
5c992bf
Compare
vursen
changed the title
vursen
commented
Jun 25, 2022
Comment on lines
15
to
19
| it('should pass validation when the field by default', () => { | ||
| expect(field.checkValidity()).to.be.true; | ||
| expect(field.validate()).to.be.true; | ||
| expect(field.invalid).to.be.false; | ||
| }); |
There was a problem hiding this comment.
note: This is a new test.
vursen
commented
Jun 25, 2022
Comment on lines
+21
to
+26
| it('should not pass validation when the field is required and has no value', () => { | ||
| field.required = true; | ||
| expect(field.checkValidity()).to.be.false; | ||
| expect(field.validate()).to.be.false; | ||
| expect(field.invalid).to.be.true; | ||
| }); |
There was a problem hiding this comment.
note: This is a new test.
vursen
commented
Jun 25, 2022
Comment on lines
+28
to
+34
| it('should pass validation when the field is required and has a valid value', () => { | ||
| field.required = true; | ||
| field.value = '1'; | ||
| expect(field.checkValidity()).to.be.true; | ||
| expect(field.validate()).to.be.true; | ||
| expect(field.invalid).to.be.false; | ||
| }); |
There was a problem hiding this comment.
note: This is a new test.
vursen
commented
Jun 25, 2022
Comment on lines
+210
to
+217
| it('should update "invalid" state when "required" is removed', () => { | ||
| field.required = true; | ||
| field.validate(); | ||
| expect(field.invalid).to.be.true; | ||
|
|
||
| field.required = false; | ||
| expect(field.invalid).to.be.false; | ||
| }); |
There was a problem hiding this comment.
note: This is a new test.
vursen
commented
Jun 25, 2022
Comment on lines
+250
to
+258
| it('should not update "invalid" when "step" is removed but the field is still required', () => { | ||
| field.required = true; | ||
| field.step = 2; | ||
| field.validate(); | ||
| expect(field.invalid).to.be.true; | ||
|
|
||
| field.step = ''; | ||
| expect(field.invalid).to.be.true; | ||
| }); |
There was a problem hiding this comment.
note: This is a new test.
web-padawan
reviewed
Jun 27, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
number-fieldvalidation tests into a separate file for the sake of better readability.A preparation for #4095
Type of change
Checklist