-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove the default value for step #4095
Conversation
a420b80
to
b598277
Compare
c959184
to
92c300b
Compare
92c300b
to
2b2b64e
Compare
1616307
to
8b86abe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remember to update corresponding ITs in the Flow components:
Also, the logic that uses 1
as a fallback step value needs to be replicated in the Flow component, see for example how it's implemented in the TimePicker
.
Kudos, SonarCloud Quality Gate passed!
|
I checked on the Flow counterpart and looks like its step already defaults to ...so only tests will need to be updated. I'll take care of them during the next release. |
Description
This PR removes the default value for the
step
property ofnumber-field
which makes it possible to throw away the custom validation logic entirely relying on theInputConstraintsMixin
validation logic instead.Breaking changes:
step
property no longer has a default value and thereforeundefined
andnull
values are now allowed.step
property no longer leads to setting thestep
attribute on thenumber-field
host.Related to #1224
Type of change
Checklist